Skip to content

Add version check for alert settings#195

Merged
taohe1012 merged 3 commits into
mainfrom
bugfix-alert-settings
Jun 23, 2025
Merged

Add version check for alert settings#195
taohe1012 merged 3 commits into
mainfrom
bugfix-alert-settings

Conversation

@taohe1012

Copy link
Copy Markdown
Contributor

Description

Add version check for alert settings

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
  • FT
    image

@codecov-commenter

codecov-commenter commented Jun 22, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (c1758bc) to head (bbbe472).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/alert_settings.py 88.46% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   90.34%   90.35%   +0.01%     
==========================================
  Files         143      143              
  Lines       16710    16766      +56     
  Branches     2372     2379       +7     
==========================================
+ Hits        15096    15149      +53     
  Misses        946      946              
- Partials      668      671       +3     
Flag Coverage Δ
units 90.35% <95.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

forrestxia
forrestxia previously approved these changes Jun 23, 2025
@taohe1012 taohe1012 marked this pull request as ready for review June 23, 2025 07:35
@taohe1012 taohe1012 merged commit de40089 into main Jun 23, 2025
22 checks passed
@taohe1012 taohe1012 deleted the bugfix-alert-settings branch June 23, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants