feat(plugin): add runWithNoSelection option#4032
Open
ykgoesdumb wants to merge 1 commit into
Open
Conversation
Plugins exit early when no resource is selected, so they cannot be run in an empty namespace. Add an opt-in runWithNoSelection flag (default false) that lets a plugin run without a selection. The viewer's namespace is used for $NAMESPACE so namespace-scoped plugins keep working. Closes derailed#3992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins currently exit early when no resource is selected, so they cannot be triggered in an empty namespace (#3992).
This adds an opt-in
runWithNoSelectionplugin option (default false, so existing plugins are unaffected). When enabled, the plugin runs even without a selection, and$NAMESPACEfalls back to the current view namespace so namespace-scoped plugins keep working.Tested with
go build, the config/view unit tests, and manually against a live cluster: a plugin with the flag runs in an empty namespace with$NAMESPACEpopulated, while a plugin without it behaves as before.Closes #3992