CCCT-2457 PersonalId Profile Screen Phase Two

[conroy-ricketts]

CCCT-2457

Technical Summary

Phase 2 of the Manage Profile feature: sets up the navigation scaffolding that later phases build on.

There's not really much new UI to show for this.

Safety Assurance

Safety story

What gives me confidence:

• I ran the app on an emulator, temporarily revealing the drawer link, and confirmed the Profile screen opens.
• The change is additive and dark-launched — the new activity is not reachable through the UI until a later phase reveals the drawer link.

Risks to review:

• Shared Safe Args class: this graph and nav_graph_personalid.xml both define the PersonalIdEmailVerificationFragment destination, and their argument sets must stay in sync or the build breaks. Nothing automated guards this coupling.
• The screen fragments are placeholders rendering empty views; there is no screen behavior to verify in this phase.

[conroy-ricketts]

Suggested Review Order

• app/res/navigation/nav_graph_personalid_profile.xml — defines the destinations, actions, and the shared-Args constraint; the crux of the change
• app/res/layout/activity_personalid_profile.xml — host layout: appbar include + nav-host container
• app/src/org/commcare/activities/connect/PersonalIdProfileActivity.kt — wires the host to the graph and action bar
• app/src/org/commcare/fragments/personalId/PersonalIdProfileFragment.kt — placeholder start destination
• app/src/org/commcare/fragments/personalId/PersonalIdEditProfileFragment.kt — placeholder edit destination

[coderabbitai]

📝 Walkthrough

Walkthrough

PersonalIdProfileActivity is refactored from CommCareActivity to NavigationHostCommCareActivity, gaining a layout resource (activity_personalid_profile) and a nav host fragment (profile_nav_host). A new layout file adds a toolbar and FragmentContainerView/NavHostFragment. A new navigation graph defines three destinations—PersonalIdProfileFragment, PersonalIdEditProfileFragment, and PersonalIdEmailVerificationFragment—connected by two actions, with typed arguments on the email verification destination. Two stub fragments (PersonalIdProfileFragment, PersonalIdEditProfileFragment) are added, each returning a bare View from onCreateView.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• dimagi/commcare-android#3761: Introduced the initial stub PersonalIdProfileActivity extending CommCareActivity, which this PR refactors into a navigation-host activity with a full nav graph.
• dimagi/commcare-android#3770: Uses the workflow argument on PersonalIdEmailVerificationFragment that this PR declares in nav_graph_personalid_profile.xml.

Suggested labels

skip-integration-tests

Suggested reviewers

• shubham1g5
• OrangeAndGreen
• Jignesh-dimagi

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description includes a clear technical summary referencing the feature phase and architecture, safety assurance with both confidence factors and known risks, but lacks explicit sections for Product Description and the Labels and Review checklist.
Title check	✅ Passed	The title 'CCCT-2457 PersonalId Profile Screen Phase Two' directly corresponds to the PR's main objective of adding navigation scaffolding and UI infrastructure for Phase 2 of the Manage Profile feature, establishing a new PersonalIdProfileActivity with its navigation graph and placeholder fragments.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch CCCT-2457-personalid-profile-screen-phase-two

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.97%. Comparing base (87d4bf2) to head (d3802e1).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3772      +/-   ##
============================================
+ Coverage     25.96%   25.97%   +0.01%     
- Complexity     4408     4420      +12     
============================================
  Files           953      958       +5     
  Lines         57366    57485     +119     
  Branches       6824     6852      +28     
============================================
+ Hits          14893    14932      +39     
- Misses        40640    40714      +74     
- Partials       1833     1839       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.