Introduce datastructures from committime cleanup#1043
Conversation
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Test images available! 🧪🚀 To test operator with them, run To clean up environment afterwards, run |
|
|
||
|
|
||
| @attrs.frozen | ||
| class GitRepo: |
There was a problem hiding this comment.
This is a replace of CommitMetric right?
If so, please checks the changes here #900 so they are also applied here
And if you want, you can look into this issue #903
There was a problem hiding this comment.
It is not a replacement, but is part of the replacement input.
Mind if I ask a few more questions in #900?
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
|
Test images available! 🧪🚀 To test operator with them, run To clean up environment afterwards, run |
|
@KevinMGranger: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I'm splitting up #720 into pieces so it's easier to review. This is an unobtrusive change, just copying over datastructures from that PR. (And unit tests for one of them).
Side note:
make unit-testsgives me a bunch ofModuleNotFoundError: No module named 'exporters'errors. What gives?