Airgap possiblities#459
Conversation
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @ColonelBundy. Thanks for your PR. I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
There was a problem hiding this comment.
Hi @ColonelBundy, we're looking into this, and grateful for your contribution! There's just a couple of things we should address:
- We need the defaults to live in the charts. See the rationale below.
- We'll need to update the chart version(s). If you haven't already, you can set up the development environment to do this automatically (and have it run a git commit hook to verify you've done this!)
| # Specify images and their versions | ||
| # override for airgap possiblities. | ||
| images: | ||
| oauth_proxy: image-registry.openshift-image-registry.svc.cluster.local:5000/openshift/oauth-proxy:v4.4 | ||
| thanos: quay.io/thanos/thanos:v0.8.1 | ||
| thanos_proxy: registry.redhat.io/openshift3/oauth-proxy:v3.11 | ||
| web_terminal_tooling: quay.io/wto/web-terminal-tooling:1.2 |
There was a problem hiding this comment.
If these become mandatory values in values.yaml, then this becomes a breaking change. Right now, the configuration workflow is editing the values.yaml file in place instead of overriding it with various helm flags. We also want a minimalist values.yaml to still be valid.
To solve those problems, we should have these as defaults within the chart itself. In other words, image: {{ .Values.images.thanos | default "quay.io/thanos/thanos:v0.8.1" }}
openshift-merge-robot
added
the
needs-rebase
|
@ColonelBundy: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
PR triage: |
|
Note: will this address #131 ? |
|
@ColonelBundy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Describe the behavior changes introduced in this PR
Linked Issues?
None
Testing Instructions
Override values in values.yaml.