Skip to content

Feature/suffle improvements#100

Merged
einsteinx2 merged 4 commits into
einsteinx2:masterfrom
gersonup:feature/suffle-improvements
Sep 20, 2024
Merged

Feature/suffle improvements#100
einsteinx2 merged 4 commits into
einsteinx2:masterfrom
gersonup:feature/suffle-improvements

Conversation

@gersonup

Copy link
Copy Markdown
Contributor
  1. Update LocalPlaylistStore.createShuffleQueue to first insert the current playing song as the first song, then update the randomizeSql query to exclude that song.
Screenshot 2024-09-20 at 5 18 59 PM
  1. Update PlayQueue.shuffleToggle to not call playSong(position:) because that stops the music and manually set currentIndex to 0.
  2. Instead tell StreamManager to removeAllStreams(except: Song) passing in the current playing song then call fillStreamQueue.
Screenshot 2024-09-20 at 5 20 02 PM
  1. Then also need to modify shuffleToggle so that when you switch back from shuffle to regular play queue, it should also not stop playing the music. It should be similar to the above but set currentIndex to the index of the current playing song in the play queue playlist.
Screenshot 2024-09-20 at 5 21 54 PM
  1. Fix the PlayerViewController shuffle loader hiding the HUD in the right threath.
Screenshot 2024-09-20 at 5 22 57 PM

@einsteinx2 einsteinx2 merged commit 5c467df into einsteinx2:master Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants