Feature/suffle improvements#100
Merged
einsteinx2 merged 4 commits intoSep 20, 2024
Merged
Conversation
gersonup
commented
Sep 20, 2024
Contributor
- Update LocalPlaylistStore.createShuffleQueue to first insert the current playing song as the first song, then update the randomizeSql query to exclude that song.
- Update PlayQueue.shuffleToggle to not call playSong(position:) because that stops the music and manually set currentIndex to 0.
- Instead tell StreamManager to removeAllStreams(except: Song) passing in the current playing song then call fillStreamQueue.
- Then also need to modify shuffleToggle so that when you switch back from shuffle to regular play queue, it should also not stop playing the music. It should be similar to the above but set currentIndex to the index of the current playing song in the play queue playlist.
- Fix the PlayerViewController shuffle loader hiding the HUD in the right threath.
…other improvements
…sition on shuffleToggle method and restore the changes on createShuffleQueue about the clear the play queue
einsteinx2
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.