Bugfix/not properly hiding the delete button in the picker equalizer#104
Merged
einsteinx2 merged 3 commits intoNov 19, 2024
Conversation
einsteinx2
approved these changes
Nov 19, 2024
gersonup
added a commit
to gersonup/iSubMusicStreamer
that referenced
this pull request
Nov 19, 2024
…insteinx2#104) * remove redundant if sentence in updatePresetPicker method * create helper functions to handle the logic for showing/hiding the save and delete buttons * implement the handlers to update save and delete preset button in updatePresetPicker method
einsteinx2
pushed a commit
that referenced
this pull request
Nov 22, 2024
…et (#105) * validate if there is not point views the BassPlayer then get the point view from the plist presets - normalize tap point into the touchesBegan method * scale point to parentSize on equilizerPointView init * validate if the array index when remove a point is into the array count of equalizer value * Bugfix/not properly hiding the delete button in the picker equalizer (#104) * remove redundant if sentence in updatePresetPicker method * create helper functions to handle the logic for showing/hiding the save and delete buttons * implement the handlers to update save and delete preset button in updatePresetPicker method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the delete button is hidden in the picker when on presets. I removed redundant code and implemented handler methods for showing or hiding the save and delete buttons for more readable and scalable code.
simulator-screen-recording-iphone-16-pro-2024-10-30-at-16_vKNYWCBB.1.1.mp4