fix transparent current playlist view controller nav bar#87
Merged
einsteinx2 merged 1 commit intoOct 27, 2024
einsteinx2:hotfix/cover-art-issue-and-ios13-missing-iconsfrom
mattneub:transparent-current-playlist-nav-bar
Merged
fix transparent current playlist view controller nav bar#87einsteinx2 merged 1 commit intoeinsteinx2:hotfix/cover-art-issue-and-ios13-missing-iconsfrom mattneub:transparent-current-playlist-nav-bar
einsteinx2 merged 1 commit into
einsteinx2:hotfix/cover-art-issue-and-ios13-missing-iconsfrom
mattneub:transparent-current-playlist-nav-bar
Conversation
einsteinx2
approved these changes
Oct 27, 2024
einsteinx2
merged commit d2b05e8
into
einsteinx2:hotfix/cover-art-issue-and-ios13-missing-icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the navigation bar above the current playlist was transparent and so was hard to see. (Perhaps the bug only manifests itself when you're building in a current version of Xcode, but no matter.)
How to test
Add something to the queue and start playing it. OK, you can stop playing it now; the point is that you are now on the player screen for that song. Tap the queue icon at the top right. You are now on the screen in question! Previously, the words "Done" and "Play Queue" were hard to see because the nav bar surrounding them was transparent. Now they aren't. This is what it looks like now on my device:
I'm not sure what the intended background color was, but this looks good and harmonizes with the rest of the view in both light and dark mode.