Skip to content

make track list cells display entire album and artist#90

Closed
mattneub wants to merge 1 commit into
einsteinx2:hotfix/cover-art-issue-and-ios13-missing-iconsfrom
mattneub:album-track-variable-cell-height
Closed

make track list cells display entire album and artist#90
mattneub wants to merge 1 commit into
einsteinx2:hotfix/cover-art-issue-and-ios13-missing-iconsfrom
mattneub:album-track-variable-cell-height

Conversation

@mattneub

Copy link
Copy Markdown

This PR fixes what I regard as iSub's primary shortcoming: in a list of tracks, the track names (i.e. the song titles) are so curtailed as to be useless, especially in the area of my primary listening, classical music. This is what a typical album tracks list looks like now:

Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-23 at 11 06 43

After this PR , that same screen looks like this:

Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-23 at 11 07 59

As you can see, the full title and artist are now displayed. This change is visible in all places where we displaying individual tracks / songs of an album, but nowhere else; for example, the Songs list and the Playlist (queue) are unaffected. If you're in doubt about the desirability of this for all users, it would be a simple matter to make it a pref that the user can toggle.

@einsteinx2

Copy link
Copy Markdown
Owner

This is an interesting use case that I wasn't aware of. I actually already have an auto scrolling label that's used to show long artist and album names, but only in certain places. I think way back when I wrote it, I tried it in table cells but it was too much movement when every cell had their text sliding back and forth. This is a great alternative and I think has better usability.

I agree I think some users will not like it, but I also agree adding a setting would be trivial or even maybe an overall "compact" mode or something like that.

I'm going to keep this PR open for now because I'd like to make sure to implement this or something very similar in the new Swift rewrite.

Thanks again for all of these PRs and again apologies for the late responses!!

@mattneub mattneub closed this by deleting the head repository Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants