tests: Migrate watch tests to common pkg

[joshjms]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Ref: #13637, #20607

/cc @yagikota @serathius

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshjms
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joshjms]

I'll make it not draft to test the CI :)

[joshjms]

/hold

[joshjms]

On closer inspection the watch tests in e2e is quite different in purpose than the one in integration :) Should I keep them separated?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.97%. Comparing base (61d54cb) to head (7113685).
⚠️ Report is 379 commits behind head on main.

Additional details and impacted files

see 149 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20837      +/-   ##
==========================================
- Coverage   68.39%   61.97%   -6.43%     
==========================================
  Files         429      416      -13     
  Lines       35281    34193    -1088     
==========================================
- Hits        24132    21190    -2942     
- Misses       9742    11434    +1692     
- Partials     1407     1569     +162     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d54cb...7113685. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[yagikota]

@joshjms

Can you write PR description in more detail? You can refer to my PR for reference.

[yagikota]

@joshjms

The tests/e2e/watch_test.go contains some tests:
First, you need to determine which tests should be migrated to common and which should remain as they are.

---

• TestWatchDelayForPeriodicProgressNotification
• TestWatchDelayForManualProgressNotification
• TestWatchDelayForEvent

To understand these tests, you need to read these references:

• #15402 (comment)
• #15431

In my opinion, these tests should not be migrated to common.
As described in the discussion, they validate watch behavior over a single persistent gRPC(HTTP/2) connection. Running them under tests/common would switch the e2e runner to etcdctl-based clients, where each call is executed in a separate process/connection. That masks the very class of bugs we want to catch (e.g., multiple requests over one connection).

---

• TestDeleteEventDrop_Issue18089

See #18201 for the backgroud of this test.

It's better to migrate this test to tests/e2e/reproduce_18089_test.go to align with other reproduction purpose tests.

---

• TestStartWatcherFromCompactedRevision

See #18274 for the background.

It can probably be migrated to tests/common.

---

• TestResumeCompactionOnTombstone

See https://github.com/etcd-io/etcd/pull/191884 for the background.

I'm not sure why this test exists in tests/e2e/watch_test.go. tests/e2e/resume_compaction_tombstone_test.go or something would be better.
Since failpoint injection is used in this test, it's better to keep it in tests/e2e/.

---

[yagikota]

@joshjms

Are you still working on this PR?
If you are busy, I'll take over.

[joshjms]

Are you still working on this PR?
If you are busy, I'll take over.

Hi @yagikota , really sorry yes I'm still unavailable 🥹 . I can get back to work on this exactly next week if that's alright with you.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivanvc]

Discussed during our triage meeting. @joshjms, are you still working on this? Or can we have someone else take over your work?

Thanks :)