Skip to content

etcdutl: add cases to hashkv_command_test#21201

Open
silentred wants to merge 1 commit into
etcd-io:mainfrom
silentred:etcdutl
Open

etcdutl: add cases to hashkv_command_test#21201
silentred wants to merge 1 commit into
etcd-io:mainfrom
silentred:etcdutl

Conversation

@silentred

Copy link
Copy Markdown
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The root cause in #21106 is that when there are keys with leases in db, the recovering process of store panics at https://github.com/etcd-io/etcd/blob/main/server/storage/mvcc/kvstore.go#L395 , before attaching keys to leases.
Therefore, I added a case to hashkv_command_test for the scenario described above.
cc @fuweid @ahrtr @serathius

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: silentred
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

Copy link
Copy Markdown

Hi @silentred. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread etcdutl/etcdutl/hashkv_command_test.go Outdated
@silentred silentred force-pushed the etcdutl branch 2 times, most recently from 3b782e5 to 1dc2e52 Compare January 27, 2026 13:51
@silentred silentred changed the title add cases to hashkv_command_test etcdutl: add cases to hashkv_command_test Feb 3, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added stale and removed stale labels May 5, 2026
@ahrtr ahrtr self-requested a review May 14, 2026 18:06
Comment thread etcdutl/etcdutl/hashkv_command_test.go Outdated
Comment thread etcdutl/etcdutl/hashkv_command.go Outdated
Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.24%. Comparing base (ab9157d) to head (d49fd2d).
⚠️ Report is 487 commits behind head on main.

Additional details and impacted files

see 136 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21201      +/-   ##
==========================================
+ Coverage   68.47%   70.24%   +1.77%     
==========================================
  Files         429      426       -3     
  Lines       35288    35314      +26     
==========================================
+ Hits        24162    24806     +644     
+ Misses       9736     9126     -610     
+ Partials     1390     1382       -8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9157d...d49fd2d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@silentred

Copy link
Copy Markdown
Contributor Author

/retest

@ahrtr

ahrtr commented May 21, 2026

Copy link
Copy Markdown
Member

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants