etcdutl: add cases to hashkv_command_test#21201
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: silentred The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @silentred. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3b782e5 to
1dc2e52
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 136 files with indirect coverage changes @@ Coverage Diff @@
## main #21201 +/- ##
==========================================
+ Coverage 68.47% 70.24% +1.77%
==========================================
Files 429 426 -3
Lines 35288 35314 +26
==========================================
+ Hits 24162 24806 +644
+ Misses 9736 9126 -610
+ Partials 1390 1382 -8 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/retest |
|
/ok-to-test |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
The root cause in #21106 is that when there are keys with leases in db, the recovering process of
storepanics at https://github.com/etcd-io/etcd/blob/main/server/storage/mvcc/kvstore.go#L395 , before attaching keys to leases.Therefore, I added a case to hashkv_command_test for the scenario described above.
cc @fuweid @ahrtr @serathius