refactor(locale): add en_NP and change ne to Devangari#3868
Open
matthewmayer wants to merge 1 commit into
Open
refactor(locale): add en_NP and change ne to Devangari#3868matthewmayer wants to merge 1 commit into
matthewmayer wants to merge 1 commit into
Conversation
Fixes faker-js#3655 An alternative approach to faker-js#3828 without semver-major breaking changes
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewmayer
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3868 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 908 917 +9
Lines 3159 3168 +9
Branches 581 564 -17
=======================================
+ Hits 3125 3134 +9
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
ST-DDT
added
c: refactor
Member
|
I would still classify this as expectation breaking, though I wont block it. |
Contributor
Author
i see where you're coming from, though i'd say we have a general policy that changes/improvements to data can be done in any patch release. This isn't much different to for example someone relying on:
and then a patch release adds localized location.state data for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3655
An alternative approach to #3828 without needing semver-major breaking changes. The existing English Nepal content is copied to en_NP, and ne is replaced with Devangari transliterations for city names, state names, first and last names.