Skip to content

chore: move modules to dedicated files#3890

Open
Shinigami92 wants to merge 1 commit into
nextfrom
refactor-extract-module-class-files
Open

chore: move modules to dedicated files#3890
Shinigami92 wants to merge 1 commit into
nextfrom
refactor-extract-module-class-files

Conversation

@Shinigami92

@Shinigami92 Shinigami92 commented Jun 13, 2026

Copy link
Copy Markdown
Member

@Shinigami92 Shinigami92 self-assigned this Jun 13, 2026
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 13, 2026 11:09
@netlify

netlify Bot commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 8718bdf
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a2d3a8449864d00088dbcbc
😎 Deploy Preview https://deploy-preview-3890.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jun 13, 2026
@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.54246% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.84%. Comparing base (143789e) to head (8718bdf).

Files with missing lines Patch % Lines
src/modules/helpers/module.ts 94.84% 15 Missing and 2 partials ⚠️
src/modules/person/module.ts 94.02% 2 Missing and 2 partials ⚠️
src/modules/commerce/module.ts 98.59% 1 Missing ⚠️
src/modules/phone/module.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3890   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         910      910           
  Lines        3198     3198           
  Branches      575      592   +17     
=======================================
  Hits         3161     3161           
  Misses         33       33           
  Partials        4        4           
Files with missing lines Coverage Δ
src/modules/airline/module.ts 100.00% <100.00%> (ø)
src/modules/animal/module.ts 100.00% <100.00%> (ø)
src/modules/book/module.ts 100.00% <100.00%> (ø)
src/modules/color/module.ts 100.00% <100.00%> (ø)
src/modules/company/module.ts 100.00% <100.00%> (ø)
src/modules/database/module.ts 100.00% <100.00%> (ø)
src/modules/datatype/module.ts 100.00% <100.00%> (ø)
src/modules/date/module.ts 100.00% <100.00%> (ø)
src/modules/finance/module.ts 100.00% <100.00%> (ø)
src/modules/food/module.ts 100.00% <100.00%> (ø)
... and 17 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92

Copy link
Copy Markdown
Member Author

This PR is very easy to review, because the files were just renamed and index reexports it

you can compare line changes:

@ST-DDT ST-DDT added this to the v10.x milestone Jun 13, 2026

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is very easy to review, because the files were just renamed and index reexports it.

While this is true, it does cause a lot of more work for the SMF PRs than just doing it as part of the SMF PRs.

I'll find a way to automate the SMF refactoring again and then just rebase my SMF PRs, so I don't loose all my work/don't have to reject this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants