feat: add support for cross-package generic types#105
Merged
franklinkim merged 4 commits intoMay 26, 2026
Conversation
franklinkim
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add cross-package generic type support to the code generator. Generic types referenced across package boundaries (e.g.
private.Envelope[server.Item]) now carry their type arguments through parsing, resolution, and into both Go and TypeScript code generation.Type of Change
Changes
model.ValuegainsTypeArgs []*Valueslot; canonical home for generic instantiations regardless of underlying Scalar/StructType kind.internal/parser/typereader.go:IndexExpr/IndexListExprpush directly tov.TypeArgsafter recursing into the generic base type. Handles both cross-package selector idents (parsed asScalar) and same-package idents (parsed asStructType).internal/parser/servicereader.go:loadFlatStructsValue,needsWorkValue,getStructTypesForField,getScalarForFieldwalkvalue.TypeArgsuniformly so dependency resolution and import collection reach into generic arguments.internal/codegen/gocode.go: newrenderGoTypeArgshelper; both Scalar and StructType render paths emit[A, B].extractImportValuewalks TypeArgs so cross-package args are imported.internal/codegen/typescript.go:renderTSTypeArgscalled from Scalar and StructType branches so cross-package generics render<A, B>correctly.tests/generics/: new test fixture covering same-package + cross-package generics, pointer-to-generic, nested generics, generics of foreign types. Bun-based TS client tests roundtrip through a real server.Checklist