This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Enabled analytics logging to opensearch#9145
Draft
ashish-aesthisia wants to merge 1 commit into
Draft
Conversation
barankyle
approved these changes
Oct 30, 2023
|
|
||
| let lastTimestamp: string | ||
| let analyticsData: any[] = [] | ||
| const collectedData: any[] = [] |
Contributor
There was a problem hiding this comment.
Will collectedData continue to grow in memory infinitely? I think it will also repeat a lot of data because of that. Unless you're filtering on the Opensource ingest side.
| const currentTimestamp = new Date().toISOString() | ||
|
|
||
| if (lastTimestamp) { | ||
| analyticsData = analyticsData.filter((data) => { |
Contributor
There was a problem hiding this comment.
I don't believe there is any data in analyticsData. Plus it is not being used.
DanielBelmes
suggested changes
Oct 30, 2023
DanielBelmes
left a comment
DanielBelmes
left a comment
Contributor
There was a problem hiding this comment.
I think there's some changes needed to ensure we're not growing in memory. Plus I think the analyticsData section isn't functioning in its current state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at c6cf091
This pull request implements analytics collection for the task server. It adds a new file
collect-analytics.tsthat handles the data processing and storage.References
closes #insert number here
Explanation
🤖 Generated by Copilot at c6cf091
packages/taskserver/src/collect-analytics.ts)🤖 Generated by Copilot at c6cf091
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist