fix: preserve newlines in ACMP test cases#673
Open
mbicl wants to merge 2 commits into
Open
Conversation
Previously, the ACMP parser used `textContent` to extract test inputs and outputs, which ignored `<br>` tags and flattened multi-line test cases into a single line. This commit updates the parser to use `innerText`, which correctly preserves visual formatting, including `<br>` tags and newlines, ensuring test cases are parsed with the correct structure.
Previously, the ACMP parser used `textContent` to extract test inputs and outputs, which ignored `<br>` tags and flattened multi-line test cases into a single line. This commit updates the parser to use `innerText`, which correctly preserves visual formatting, including `<br>` tags and newlines, ensuring test cases are parsed with the correct structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the ACMP parser used
textContentto extract test inputs and outputs, which ignored<br>tags and flattened multi-line test cases into a single line. This commit updates the parser to useinnerText, which correctly preserves visual formatting, including<br>tags and newlines, ensuring test cases are parsed with the correct structure.I tested this change locally using two different problem pages from ACMP (using cpeditor.org):
before change:
after change:
2. second problem - both working good in this case.