Skip to content

Manage multiple authors#147

Open
louckousse wants to merge 4 commits into
kefranabg:masterfrom
louckousse:multi-authors
Open

Manage multiple authors#147
louckousse wants to merge 4 commits into
kefranabg:masterfrom
louckousse:multi-authors

Conversation

@louckousse

Copy link
Copy Markdown

Fix #146

@codecov

codecov Bot commented Oct 5, 2019

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (32af6a2) to head (797aa4b).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          197       197           
  Branches        21        21           
=========================================
  Hits           197       197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patou

patou commented Oct 9, 2019

Copy link
Copy Markdown

And if there are not the same number of authors names and github names or twitter ?

Maybe, if there are multiple authors, ask github or twitter for each ?

@louckousse

Copy link
Copy Markdown
Author

person1,,person3 TADAM problem solved. The way questions are asked it's too complicated for me to loop on these.

@kefranabg

Copy link
Copy Markdown
Owner

Hey @louckousse (sorry for the delay) thanks for your work 💪 I'll try to improve the rendering part by moving the code from ejs to node (using inquirer transformer function), it will allow us to make this code testable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the possibility to add multiple author during the questions

3 participants