fix: data source temporary views#2059
Open
shehabgamin wants to merge 30 commits into
Open
Conversation
Spark 3.5.7 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff--- before.txt 2026-06-14 11:31:22.712096054 +0000
+++ after.txt 2026-06-14 11:31:23.006098132 +0000
@@ -900,0 +901 @@
+pyspark/sql/tests/connect/test_parity_datasources.py::DataSourcesParityTests::test_multiline_csvFailed Tests |
Spark 4.1.1 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff--- before.txt 2026-06-14 11:33:54.120404715 +0000
+++ after.txt 2026-06-14 11:33:54.414410371 +0000
@@ -1684,0 +1685 @@
+pyspark/sql/tests/connect/test_parity_datasources.py::DataSourcesParityTests::test_multiline_csvFailed Tests(truncated) |
Ibis Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #2059 +/- ##
==========================================
- Coverage 77.12% 76.57% -0.55%
==========================================
Files 997 997
Lines 158202 158439 +237
==========================================
- Hits 122012 121325 -687
- Misses 36190 37114 +924
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
shehabgamin
added
run spark tests
shehabgamin
changed the title
shehabgamin
commented
Jun 14, 2026
| let file_group = FileGroup::from(vec![partitioned_file]); | ||
| let file_scan_config = FileScanConfigBuilder::new(object_store_url, file_source) | ||
| .with_file_groups(vec![file_group]) | ||
| .with_expr_adapter(Some(Arc::new(SchemaEvolutionPhysicalExprAdapterFactory {}))) |
Contributor
Author
There was a problem hiding this comment.
@lonless9 I think this was missing from here. Let me know if it should be removed though!
shehabgamin
commented
Jun 14, 2026
| .with_file_groups(input.file_groups) | ||
| .with_constraints(input.constraints) | ||
| .with_statistics(input.statistics) | ||
| .with_expr_adapter(Some(Arc::new(SchemaEvolutionPhysicalExprAdapterFactory {}))) |
Contributor
Author
shehabgamin
commented
Jun 14, 2026
| .and_then(|x| x.get(&cache_key)) | ||
| { | ||
| if cached.is_valid_for(meta) { | ||
| // Skip a cached entry whose column count differs to avoid an out-of-bounds panic |
Contributor
Author
There was a problem hiding this comment.
This was a bad bug that broadly impacted any code paths that relied on list_files_for_scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.