Skip to content

fix: monitor table improvement#7474

Draft
louislam wants to merge 8 commits into
masterfrom
dev-mariadb-strict
Draft

fix: monitor table improvement#7474
louislam wants to merge 8 commits into
masterfrom
dev-mariadb-strict

Conversation

@louislam

@louislam louislam commented Jun 2, 2026

Copy link
Copy Markdown
Owner

It is really bad to keep adding more columns to monitor table, I think we should stop it.

Set the test container to InnoDB Strict Mode in order to fail the test.

It is too late and not possible to enable InnoDB Strict Mode already.

But still want to avoid more columns.

Plan?

  • add one json field?
  • one to one table to store extra data?
Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

@louislam louislam changed the title fix: Fullfill MariaDB InnoDB Strict Mode fix: monitor table improvement Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant