fix: handle non-JSON AI responses gracefully in ai-suggestion-notes#7131
Open
saewitz wants to merge 2 commits into
Open
fix: handle non-JSON AI responses gracefully in ai-suggestion-notes#7131saewitz wants to merge 2 commits into
saewitz wants to merge 2 commits into
Conversation
When the AI returns a response that doesn't contain valid JSON, fixAndParseJsonObjectFromString throws an error that hits Sentry. Now we catch that error and return empty suggestions instead. Slack thread: https://masslight.slack.com/archives/C0AAK8SAT61/p1776457202614769?thread_ts=1776454949.564059&cid=C0AAK8SAT61 https://claude.ai/code/session_016mJA4Q7KVNdzdf8zWR9GLJ
Per feedback, return 500 status code when the AI returns invalid JSON instead of returning an empty suggestions list with 200. https://claude.ai/code/session_01Sago85zoPBvjZEEQbugd5d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixAndParseJsonObjectFromStringthrows an error that hits SentryTest plan
"AI returned invalid JSON response"Slack thread: https://masslight.slack.com/archives/C0AAK8SAT61/p1776457202614769?thread_ts=1776454949.564059&cid=C0AAK8SAT61
https://claude.ai/code/session_01Sago85zoPBvjZEEQbugd5d