Remove node16 from pipelines-agent package#5555
Open
Copilot wants to merge 3 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/microsoft/azure-pipelines-agent/sessions/67f8d48f-0314-47f9-9de9-5811eb9289f1 Co-authored-by: tarunramsinghani <2929463+tarunramsinghani@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/azure-pipelines-agent/sessions/67f8d48f-0314-47f9-9de9-5811eb9289f1 Co-authored-by: tarunramsinghani <2929463+tarunramsinghani@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
tarunramsinghani
May 7, 2026 07:27
View session
…t fallback in runsvc.sh Agent-Logs-Url: https://github.com/microsoft/azure-pipelines-agent/sessions/ed5cd3e4-d7ae-4624-9003-b9a05f53fbe9 Co-authored-by: tarunramsinghani <2929463+tarunramsinghani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Node 16 is EOL. The
pipelines-agentpackage already strips node6 and node10; this PR extends that to node16.vsts-agentretains node16 unchanged.Description
Removes Node 16 from the
pipelines-agentpackage while keeping it in thevsts-agentpackage.src/dev.shexport INCLUDE_NODE16="false"to thepipelines-agentpackage type block, alongside the existing exclusions of node6 and node10.src/Misc/externals.shINCLUDE_NODE16=${INCLUDE_NODE16:-true}flag (defaulting totrue), mirroring the existingINCLUDE_NODE6andINCLUDE_NODE10pattern.if [[ "$INCLUDE_NODE16" == "true" ]]guards.rmoflib/,npm,npx,corepack) runs unconditionally, consistent with the node6 and node10 cleanup pattern.src/Misc/layoutbin/runsvc.shnode24 → node20_1 → node16, with node24 as the default, so the agent service prefers the newest available runtime and degrades gracefully on platforms where newer versions are absent.Behavior:
vsts-agent(default)pipelines-agentRisk Assessment (Low)
pipelines-agentalready excludes older runtimes with no issues.INCLUDE_NODE16defaults totrue, sovsts-agentbuilds are unaffected. Therunsvc.shfallback degrades gracefully.Unit Tests Added or Updated (No)
Build/packaging scripts only — no testable logic changes.
Additional Testing Performed
None beyond code review.
Change Behind Feature Flag (Yes)
INCLUDE_NODE16defaults totrue; onlyPACKAGE_TYPE=pipelines-agentflips it tofalse.Tech Design / Approach
Follows the established
INCLUDE_NODE6/INCLUDE_NODE10exclusion pattern. Node16 cleanup is unconditional (matching node6/node10 pattern).runsvc.shfallback order isnode24 → node20_1 → node16to prefer the newest available runtime.Documentation Changes Required (No)
Logging Added/Updated (No)
Telemetry Added/Updated (No)
Rollback Scenario and Process (Yes)
Revert the three-file change. Low risk — flag defaults to
true.Dependency Impact Assessed and Regression Tested (Yes)
vsts-agentis unaffected.pipelines-agentmirrors existing node6/node10 exclusion behavior.