Normalize subtitle metadata before wanted-search storage changes#3387
Open
mjc wants to merge 13 commits into
Open
Normalize subtitle metadata before wanted-search storage changes#3387mjc wants to merge 13 commits into
mjc wants to merge 13 commits into
Conversation
Align requests floor with vendored runtime
Add shared wanted-search fixture layer Cover wanted-search fixtures with focused tests
(cherry picked from commit faa01ff) test: add mass-download fixture support test: complete mass-download fixture support test: add shared wanted database binder test: simplify wanted kind inference test: register wanted fixtures at top level test: drop unused transactional tmp fixture test: bind profile lookup to wanted test database test: bind profile list lookup to wanted fixtures
Author
|
Stack note for review: this branch is intentionally based on the PR #3383 test harness branch in my fork, but the upstream PR targets |
mjc
changed the title
mjc
force-pushed
the
mjc/wanted-search-manual-upload
branch
from
43599c4 to
d575b01
Compare
mjc
force-pushed
the
mjc/wanted-search-manual-upload
branch
from
d575b01 to
fcaec0a
Compare
mjc
force-pushed
the
mjc/wanted-search-manual-upload
branch
from
34696bd to
ab21600
Compare
Author
|
Force-pushed to clean up the branch history only. No content changes in the PR. |
mjc
force-pushed
the
mjc/wanted-search-manual-upload
branch
from
b87eb16 to
543b965
Compare
Author
|
moved the CI fix into 3383, so all the force pushes were updating that |
mjc
force-pushed
the
mjc/wanted-search-manual-upload
branch
from
543b965 to
fc53536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens manual subtitle download/upload flows and nearby subtitle metadata handling before wanted-search state is normalized.
It focuses on user-triggered subtitle paths that read profile, audio, scene-name, processing, and notification metadata. Valid behavior is preserved, while malformed or missing metadata is handled defensively.
What changed
Nonethrough manual, wanted, provider, and mass-download payloads.Why this is separate
Manual download and upload are user-facing paths that can feed or refresh wanted-search state. Hardening them before the normalized wanted-state PR keeps the later schema/query diff from also carrying unrelated metadata fixes.
Tests
The added tests cover manual search and manual download with missing or malformed profile data, missing audio-language rows, missing scene names, absent notification messages, nonstandard episode display values, manual upload format decisions with incomplete profile data, and upload post-processing with partial audio-language dictionaries. The tests use real transactional movie/episode rows and mock only external side effects such as saving subtitles, sync, history, notifications, and post-processing.