Security: Unsafe Stack Variable Deletion Without Proper Validation#456
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
…oper vali The delete_stack function in api_stack.py deletes stack frame members based on user-provided name and address. While it checks for special frame members, the validation relies on IDA's internal APIs which may have edge cases. More critically, the declare_stack function allows creating arbitrary stack variables with user-controlled names, offsets, and types, which could corrupt function frames or be exploited for memory corruption in IDA's type system. Affected files: api_stack.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Owner
|
What is an actual input that triggers a crash or exploit in IDA that these checks guard against? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The delete_stack function in api_stack.py deletes stack frame members based on user-provided name and address. While it checks for special frame members, the validation relies on IDA's internal APIs which may have edge cases. More critically, the declare_stack function allows creating arbitrary stack variables with user-controlled names, offsets, and types, which could corrupt function frames or be exploited for memory corruption in IDA's type system.
Severity:
highFile:
src/ida_pro_mcp/ida_mcp/api_stack.pySolution
Add stricter validation for stack variable offsets and sizes. Ensure type names are validated against a whitelist. Consider requiring additional confirmation for destructive operations like delete_stack that modify binary analysis state.
Changes
src/ida_pro_mcp/ida_mcp/api_stack.py(modified)Testing