Security: Output Cache Potential Information Disclosure#457
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
…sure
The rpc.py module implements an download cache for large outputs with OUTPUT_CACHE_MAX_SIZE = 100. The _generate_output_id uses UUID4 which is unpredictable, but cached outputs are accessible via /output/{output_id}.json without authentication shown in the code. If the HTTP server is exposed, this could leak sensitive analysis data from previous tool executions.
Affected files: rpc.py
Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The rpc.py module implements an download cache for large outputs with OUTPUT_CACHE_MAX_SIZE = 100. The _generate_output_id uses UUID4 which is unpredictable, but cached outputs are accessible via /output/{output_id}.json without authentication shown in the code. If the HTTP server is exposed, this could leak sensitive analysis data from previous tool executions.
Severity:
mediumFile:
src/ida_pro_mcp/ida_mcp/rpc.pySolution
Add authentication or time-limited signed URLs for cached output access. Implement cache expiration and automatic cleanup. Consider encrypting cached outputs or restricting access to the same transport session that generated them.
Changes
src/ida_pro_mcp/ida_mcp/rpc.py(modified)Testing