git-extras: fix build failure when MSYS=winsymlinks:native#6188
git-extras: fix build failure when MSYS=winsymlinks:native#6188lygstate wants to merge 1 commit into
Conversation
lygstate
force-pushed
the
git-extras-same-file-fixes
branch
from
9319ab3 to
bc7a3f1
Compare
|
cc @dscho |
lygstate
force-pushed
the
git-extras-same-file-fixes
branch
from
bc7a3f1 to
0d6a8de
Compare
|
What's the default MSYS in CI? locally. |
|
by default winsymlinks set to deep copy option, so all symlinks are actually copies of sources |
lygstate
force-pushed
the
git-extras-same-file-fixes
branch
from
0d6a8de to
59a5aca
Compare
|
OK, I switch it to MSYS=winsymlinks:native and now it's fine for bsdtar |
| bsdtar -zxf "${_realname}-${pkgver}.tar.gz" || true | ||
|
|
||
| cd "${srcdir}/${_realname}-${pkgver}" | ||
| cp bin/git-scp bin/git-rscp | ||
| MSYS=winsymlinks:native \ | ||
| bsdtar -zxf "${_realname}-${pkgver}.tar.gz" |
There was a problem hiding this comment.
Even if many people are lucky enough to run MSYS2 on a recent Windows machine in Developer Mode, not all MSYS2 users are that lucky. And those would no longer be able to use this recipe to build.
Maybe it would be better to go the other way round, using MSYS=winsymlinks:deepcopy and keep most of the original code as-is?
There was a problem hiding this comment.
The difference between winsymlinks:native and winsymlinks:nativestrict is this: If the filesystem supports native symlinks and Cygwin fails to create a native symlink for some reason, it will fall back to creating Cygwin default symlinks with winsymlinks:native, while with winsymlinks:nativestrict the symlink(2) system call will immediately fail.
So I think winsymlinks:native is a better opton indeed. According to https://cygwin.com/cygwin-ug-net/using-cygwinenv.html
There was a problem hiding this comment.
MSYS=winsymlinks:deepcopy have the following error that are hidden.:
git-extras-7.4.0/bin/git-rscp: Can't create 'git-extras-7.4.0/bin/git-rscp': No such file or directory
bsdtar: Error exit delayed from previous errors
59a5aca to
585d854
Compare
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
With substantially improved commit message, I would be totally comfortable with this change for now. https://github.blog/2022-06-30-write-better-commits-build-better-projects/ might be helpful, in particular this part:
| What you’re doing | Why you’re doing it | |
|---|---|---|
| High-level (strategic) | Intent (what does this accomplish?) | Context (why does the code do what it does now?) |
| Low-level (tactical) | Implementation (what did you do to accomplish your goal?) | Justification (why is this change being made?) |
lygstate
force-pushed
the
git-extras-same-file-fixes
branch
from
585d854 to
88f8dc3
Compare
Set MSYS=winsymlinks:deepcopy before extracting the source tarball so symlinked bin/git-scp and bin/git-rscp are materialized as separate files, avoiding "cp: 'bin/git-scp' and 'bin/git-rscp' are the same file". Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
lygstate
force-pushed
the
git-extras-same-file-fixes
branch
from
88f8dc3 to
60f20c8
Compare
lygstate
changed the title
Updated, don't know if it's OK to you. |
3 participants
…ile"