frontend: Remove sender() usage from UI handlers#13500
Open
xakep8 wants to merge 2 commits into
Open
Conversation
Warchamp7
reviewed
May 30, 2026
Warchamp7
reviewed
May 30, 2026
Warchamp7
reviewed
May 30, 2026
Warchamp7
reviewed
May 30, 2026
7185e23 to
722dd72
Compare
6149e43 to
0c113b2
Compare
b136dd1 to
43f4474
Compare
09af5d9 to
91c238c
Compare
91c238c to
e8e6093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13444
Pass source and editor context explicitly instead of recovering it through QObject::sender().
Motivation and Context
QObject::sender() is fragile in its implementation as it relies on the runtime knowledge of the sender as well as dynamic properties rather than type-safe and explicit message flows. The calling sites know where the call is from since the connections were made, and thus this information can be passed directly.
How Has This Been Tested?
Types of changes
Checklist: