Update manifest.json#11
Closed
pratikanurag wants to merge 1 commit into
Closed
Conversation
manifest_version was missing from the manifest.json file.
Owner
|
Thanks for the PR! However, considering that this repo is not intended to get out of sync with the upstream examples even if they are non-functional, I'm unfortunately not going to accept your fix. If you'd like to help, you could try running the scraper and making a PR for the whole repository, this shouldn't take more than a few minutes if everything works properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manifest_version was missing from the manifest.json file. added "manifest_version": 2 in the script