Fix invalid oxend rpc call#2252
Merged
Merged
Conversation
This call is wrong (and has always been wrong): the field should be set in the top-level parameters, not inside `fields`. In current dev lokinet, however, the invalid field becomes an error, because dev tries to parse all `fields` keys with `bool` values, and this ends up returning an error to Lokinet instead of a response, which breaks Lokinet's service node updating code.
Member
Author
|
Also noting in passing: this has been fixed for a while in the WIP code, probably because it encountered the same issue with testnet nodes at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This call is wrong (and has always been wrong): the field should be set in the top-level parameters, not inside
fields.In current dev lokinet, however, the invalid field becomes an error, because dev tries to parse all
fieldskeys withboolvalues, and this ends up returning an error to Lokinet instead of a response, which breaks Lokinet's service node updating code when used with oxend 11.