Skip to content
This repository was archived by the owner on Dec 25, 2025. It is now read-only.

Query entries from node#22

Merged
adzialocha merged 29 commits into
mainfrom
query-entries
May 14, 2021
Merged

Query entries from node#22
adzialocha merged 29 commits into
mainfrom
query-entries

Conversation

@cafca

@cafca cafca commented Apr 9, 2021

Copy link
Copy Markdown
Member

Request chat log messages from node.

Todo

  • Restructure message to not include the type. For example message.fields.date.Text becomes message.fields.date
  • Make decoded entry contents the default and not its encoded values?

cafca and others added 21 commits April 9, 2021 18:12
- move method to query entries from `Instance` to session as its not related to instances
- Make Instance.create functional instead of a static class method
- collect types in a types.ts file (I tried making an `index.d.ts` but failed)
- Rename some variables to hopefully clear up their context
Also some further refactoring to prepare for
update and delete messages
* main:
  Use stringify() for decodedEntry formatting
Now that key pair is no longer required for creating a session we don't
have to wait for it to be ready.
Comment thread src/p2panda-api/instance.ts
@cafca cafca marked this pull request as ready for review May 13, 2021 18:58
@cafca

cafca commented May 13, 2021

Copy link
Copy Markdown
Member Author

I changed the format of entries a bit as we discussed.

  • Responses return the decoded entry form with the encoded entry properties available on entry.encoded.
  • MessageFields values are untagged, i.e. you can access entry.message.fields.date instead of entry.message.fields.date.Text.

Please merge!

@adzialocha adzialocha merged commit 108c42f into main May 14, 2021
@adzialocha adzialocha deleted the query-entries branch May 14, 2021 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants