Kubelet code improvements and cleanups#16
Merged
pohly merged 3 commits intoAug 19, 2022
Merged
Conversation
bart0sh
commented
Aug 19, 2022
bart0sh
commented
- used sets instead of maps for the set of PodUIDs
- fixed lint findings
- got rid of unused leftovers from Device Manager code
Used sets API to store UIDs of pods referencing resource claims in the DRA Manager cache.
pohly
reviewed
Aug 19, 2022
| ) | ||
|
|
||
| // ManagerImpl is the structure in charge of managing Device Plugins. | ||
| // ManagerImpl is the structure in charge of managing DRA resource Plugins. |
Owner
There was a problem hiding this comment.
"resource" seems redundant here. "DRA" already contains that word.
pohly
reviewed
Aug 19, 2022
pohly
left a comment
pohly
left a comment
Owner
There was a problem hiding this comment.
Looks all reasonable to me. One nit, but we don't need to fix that now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.