Skip to content

[nxp][mcxw72] Removed Memory Manager Light#72503

Open
LeoCiobanu wants to merge 5 commits into
project-chip:masterfrom
NXP:remove-mml
Open

[nxp][mcxw72] Removed Memory Manager Light#72503
LeoCiobanu wants to merge 5 commits into
project-chip:masterfrom
NXP:remove-mml

Conversation

@LeoCiobanu

Copy link
Copy Markdown

Summary

Memory Manager Light is not supported or used anymore. It only affects one component, the SoftwareDiagnostics cluster, where it overrides diagnostic data such as GetCurrentHeapFree, GetCurrentHeapUsed and GetCurrentHeapHighWatermark.

Testing

Tested manually using TC_RR.

Signed-off-by: Leonard Ciobanu <leonard.ciobanu@nxp.com>
@github-actions github-actions Bot added platform nxp NXP platform labels Jun 10, 2026
@CLAassistant

CLAassistant commented Jun 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the NXP_USE_MML macro and its associated conditional compilation blocks across NXP platform files, defaulting to standard FreeRTOS heap management functions. A review comment suggests replacing the remaining preprocessor macros for heap size and watermark aliases with type-safe inline functions and a constexpr constant to improve type safety and adhere to modern C++ best practices.

Comment thread src/platform/nxp/common/DiagnosticDataProviderImpl.cpp Outdated
Signed-off-by: Leonard Ciobanu <leonard.ciobanu@nxp.com>
Signed-off-by: Leonard Ciobanu <leonard.ciobanu@nxp.com>
@doru91 doru91 self-requested a review June 11, 2026 10:41
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.77%. Comparing base (3c9767a) to head (4533dfb).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72503   +/-   ##
=======================================
  Coverage   55.77%   55.77%           
=======================================
  Files        1636     1636           
  Lines      111830   111830           
  Branches    13391    13391           
=======================================
  Hits        62372    62372           
  Misses      49458    49458           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

PR #72503: Size comparison from 3c9767a to 675475b

Full report (33 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
platform target config section 3c9767a 675475b change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094260 1094260 0 0.0
RAM 144882 144882 0 0.0
bl616 lighting-app bl616+thread FLASH 1105604 1105604 0 0.0
RAM 104280 104280 0 0.0
bl616+wifi+shell FLASH 1593352 1593352 0 0.0
RAM 98176 98176 0 0.0
bl702 lighting-app bl702+eth FLASH 1057262 1057262 0 0.0
RAM 108525 108525 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 896094 896094 0 0.0
RAM 105908 105908 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 777008 777008 0 0.0
RAM 103404 103404 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 789760 789760 0 0.0
RAM 108684 108684 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 738868 738868 0 0.0
RAM 97612 97612 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 719040 719040 0 0.0
RAM 97644 97644 0 0.0
efr32 lock-app BRD4187C FLASH 994312 994312 0 0.0
RAM 131292 131292 0 0.0
BRD4338a FLASH 799129 799129 0 0.0
RAM 243432 243432 0 0.0
window-app BRD4187C FLASH 1100916 1100916 0 0.0
RAM 130364 130364 0 0.0
esp32 all-clusters-app c3devkit DRAM 99772 99772 0 0.0
FLASH 1623602 1623602 0 0.0
IRAM 94776 94776 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 834248 834248 0 0.0
RAM 157602 157602 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1736628 1736628 0 0.0
RAM 215316 215316 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1625892 1625892 0 0.0
RAM 211604 211604 0 0.0
light cy8ckit_062s2_43012 FLASH 1470196 1470196 0 0.0
RAM 197436 197436 0 0.0
lock cy8ckit_062s2_43012 FLASH 1503652 1503652 0 0.0
RAM 225268 225268 0 0.0
qpg lighting-app qpg6200+debug FLASH 842424 842424 0 0.0
RAM 127908 127908 0 0.0
lock-app qpg6200+debug FLASH 782260 782260 0 0.0
RAM 118840 118840 0 0.0
realtek light-switch-app rtl8777g FLASH 688816 688816 0 0.0
RAM 101780 101780 0 0.0
lighting-app rtl8777g FLASH 729760 729760 0 0.0
RAM 102052 102052 0 0.0
stm32 light STM32WB5MM-DK FLASH 478464 478464 0 0.0
RAM 141492 141492 0 0.0
telink all-devices-app tl7218x FLASH 821274 821274 0 0.0
RAM 99020 99020 0 0.0
tlsr9118bdk40d FLASH 612594 612594 0 0.0
RAM 120152 120152 0 0.0
bridge-app tl7218x FLASH 733698 733698 0 0.0
RAM 97700 97700 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 800188 800188 0 0.0
RAM 42380 42380 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl7218x FLASH 845368 845368 0 0.0
RAM 101492 101492 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 734190 734190 0 0.0
RAM 57816 57816 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 795252 795252 0 0.0
RAM 75176 75176 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 734064 734064 0 0.0
RAM 34472 34472 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 614690 614690 0 0.0
RAM 118508 118508 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 841316 841320 4 0.0
RAM 97376 97376 0 0.0

Signed-off-by: Leonard Ciobanu <leonard.ciobanu@nxp.com>
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

PR #72503: Size comparison from 3c9767a to 4533dfb

Full report (32 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
platform target config section 3c9767a 4533dfb change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094260 1094260 0 0.0
RAM 144882 144882 0 0.0
bl616 lighting-app bl616+thread FLASH 1105604 1105604 0 0.0
RAM 104280 104280 0 0.0
bl616+wifi+shell FLASH 1593352 1593352 0 0.0
RAM 98176 98176 0 0.0
bl702 lighting-app bl702+eth FLASH 1057262 1057262 0 0.0
RAM 108525 108525 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 896094 896094 0 0.0
RAM 105908 105908 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 777008 777008 0 0.0
RAM 103404 103404 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 789760 789760 0 0.0
RAM 108684 108684 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 738868 738868 0 0.0
RAM 97612 97612 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 719040 719040 0 0.0
RAM 97644 97644 0 0.0
efr32 lock-app BRD4187C FLASH 994312 994312 0 0.0
RAM 131292 131292 0 0.0
BRD4338a FLASH 799129 799129 0 0.0
RAM 243432 243432 0 0.0
esp32 all-clusters-app c3devkit DRAM 99772 99772 0 0.0
FLASH 1623602 1623602 0 0.0
IRAM 94776 94776 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 834248 834248 0 0.0
RAM 157602 157602 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1736628 1736628 0 0.0
RAM 215316 215316 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1625892 1625892 0 0.0
RAM 211604 211604 0 0.0
light cy8ckit_062s2_43012 FLASH 1470196 1470196 0 0.0
RAM 197436 197436 0 0.0
lock cy8ckit_062s2_43012 FLASH 1503652 1503652 0 0.0
RAM 225268 225268 0 0.0
qpg lighting-app qpg6200+debug FLASH 842424 842424 0 0.0
RAM 127908 127908 0 0.0
lock-app qpg6200+debug FLASH 782260 782260 0 0.0
RAM 118840 118840 0 0.0
realtek light-switch-app rtl8777g FLASH 688816 688816 0 0.0
RAM 101780 101780 0 0.0
lighting-app rtl8777g FLASH 729760 729760 0 0.0
RAM 102052 102052 0 0.0
stm32 light STM32WB5MM-DK FLASH 478464 478464 0 0.0
RAM 141492 141492 0 0.0
telink all-devices-app tl7218x FLASH 821274 821274 0 0.0
RAM 99020 99020 0 0.0
tlsr9118bdk40d FLASH 612594 612594 0 0.0
RAM 120152 120152 0 0.0
bridge-app tl7218x FLASH 733698 733698 0 0.0
RAM 97700 97700 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 800188 800188 0 0.0
RAM 42380 42380 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl7218x FLASH 845368 845368 0 0.0
RAM 101492 101492 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 734190 734190 0 0.0
RAM 57816 57816 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 795252 795252 0 0.0
RAM 75176 75176 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 734064 734064 0 0.0
RAM 34472 34472 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 614690 614690 0 0.0
RAM 118508 118508 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 841316 841320 4 0.0
RAM 97376 97376 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants