[Bouffalo Lab] Update BFLB platform and SDK support#72571
Open
wy-hh wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a CMake-based build system for Bouffalo Lab platforms (specifically BL61X series) across the contact-sensor and lighting examples, replacing older GN configurations and updating documentation. It also refactors low-power PDS management, OpenThread initialization, and logging to support the unified 'bflb' platform layer. The review feedback highlights several critical issues, including potential null pointer dereferences in low-power and Thread stack idle checks, thread-safety concerns with local static variables in interrupt contexts, and macro safety issues in FreeRTOSConfig.h. Additionally, the reviewer noted format string mismatches, parsing bugs in the OTA script when handling parenthesized macros, and logging inconsistencies in Python scripts.
Update Bouffalo Lab platform support for the BFLB SDK, including shared BFLB platform files, lighting and contact sensor example build integration, refreshed build targets, documentation, flashing, OTA image, factory data, and SDK configuration handling. Add shared CMake handling for Bouffalo SDK builds, including a macOS workaround that removes LTO flags and disables linker plugin usage when required.
Update Bouffalo follow-up changes for PDS safety, OTA metadata parsing, logging format cleanup, generated contact sensor data model, and build target testdata.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72571 +/- ##
=======================================
Coverage 56.08% 56.08%
=======================================
Files 1640 1640
Lines 112463 112463
Branches 13316 13316
=======================================
Hits 63075 63075
Misses 49388 49388 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72571: Size comparison from ace3ccc to a1b3a5b Full report (20 builds for cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32)
|
Add the ota-requestor interface dependency when OTA requestor sources are enabled so BFLB builds pass GN include checks.
|
PR #72571: Size comparison from ace3ccc to 9b474f8 Increases above 0.2%:
Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
generation, factory data support, and documentation.
Testing
Tested commissioning, onoff toggle, boolean state report and ota upgrading with following targets: