Skip to content

[WALLET-46] Export ProofCredentialV1 and verify aud#10

Merged
frostevent merged 1 commit into
mainfrom
jeremie/wallet-46
Jun 9, 2026
Merged

[WALLET-46] Export ProofCredentialV1 and verify aud#10
frostevent merged 1 commit into
mainfrom
jeremie/wallet-46

Conversation

@frostevent

Copy link
Copy Markdown
Collaborator

Summary

  • Export the ProofCredentialV1 class from the Node entry (src/index.node.ts) so callers can narrow a ProofCredential via instanceof ProofCredentialV1 and use its accessors (givenName(), dateOfBirth(), isOver18(), etc.). ProofCredential is already re-exported via export type * from "./types.ts". Kept off the browser entry since verify/verifyVPToken are Node-only.
  • Add an optional aud parameter to verify and verifyVPToken. When supplied:
    • With a KB JWT present, it asserts kbJwt.payload.aud === aud and throws on mismatch.
    • With no KB JWT present, it throws — consistent with how a present KB JWT already requires a nonce.
    • aud is threaded through verifyVPTokenverify.

Testing

  • yarn check-all passes (format, lint, typecheck, publint).
  • Browser-graph grep after yarn build is clean (no @sd-jwt/@owf/node: leaks).
  • This repo has no automated test suite; the quality gate is yarn check-all.

Jira: https://notarize.atlassian.net/browse/WALLET-46

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@frostevent frostevent enabled auto-merge (squash) June 9, 2026 15:37
@frostevent frostevent disabled auto-merge June 9, 2026 15:37
@frostevent frostevent merged commit 849f9d4 into main Jun 9, 2026
8 checks passed
@frostevent frostevent deleted the jeremie/wallet-46 branch June 9, 2026 15:38
@frostevent frostevent mentioned this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant