fix: enable rio-window platform features in sugarloaf dev-deps#1633
Open
nikicat wants to merge 1 commit into
Open
fix: enable rio-window platform features in sugarloaf dev-deps#1633nikicat wants to merge 1 commit into
nikicat wants to merge 1 commit into
Conversation
The workspace declares rio-window with `default-features = false`, so sugarloaf's dev-dep inherited no platform features and rio-window's `platform_impl/mod.rs` triggered its "platform not supported by winit" `compile_error!` whenever `cargo test -p sugarloaf` pulled it in on Linux. rioterm avoids this by re-enabling x11/wayland through its own feature flags; sugarloaf had no equivalent, blocking `cargo test -p sugarloaf` and any sugarloaf examples that import `rio_window::...`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 38e73b0)
nikicat
force-pushed
the
fix/sugarloaf-dev-deps
branch
from
f295fe9 to
b99e9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo test -p sugarloaf(and any sugarloaf example importingrio_window::...)failed to compile on Linux with rio-window's "platform not supported by winit"
compile_error!.Details
The workspace declares rio-window with
default-features = false, so sugarloaf'sdev-dependency inherited no platform features and
platform_impl/mod.rstrippedits
compile_error!. rioterm avoids this by re-enabling x11/wayland through itsown feature flags; sugarloaf had no equivalent. This enables the rio-window
x11/wayland platform features in sugarloaf's dev-deps.
Testing
cargo test -p sugarloafnow compiles and runs on Linux.🤖 Generated with Claude Code