support width on glyph protocol but only renderer level#1650
Open
raphamorim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is completely unpolished but here's the idea:
A Glyph Protocol registration does NOT change a codepoint's logical width: the cell layout stays consistent with system
wcwidthso the cursor / selection / copy never desync with a width-unaware consumer (a shell line editor, etc.). The declaredwidthis honoured purely at render time, where the glyph overflows into the following cell(s) in pixels.It counters #1649 . So if this merges we don't need to drop width from the spec.
Due to the nature of the terminals, we will only have width respected in the render level.
However you may known that if width is 2, then applications should also give a space themselves.
and ofc you can renders as well with width 1: