Fix CVE-2025-62126: sensitive data exposure in VCL config download#15
Open
shaundma wants to merge 5 commits into
Open
Fix CVE-2025-62126: sensitive data exposure in VCL config download#15shaundma wants to merge 5 commits into
shaundma wants to merge 5 commits into
Conversation
The VCL configuration download handler in conf_page_fields() ran on
admin_init with no authentication or nonce verification, allowing
unauthenticated users to obtain sensitive data (backend IPs, purge key,
cookie name, ACLs) by POSTing to wp-admin/admin-ajax.php.
Add current_user_can('manage_options') capability check and
check_admin_referer() nonce verification before processing the download.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…es (CVE-2025-48360, CVE-2025-62126) - Add esc_attr() on all settings field outputs and post meta values - Add esc_js()/esc_html() on statistics page output (server IPs, stats JSON URLs) - Add CSRF nonce verification on console purge form submission - Add sanitize_text_field() on console purge URL and post meta save inputs - Restrict X-VC-* response headers to debug mode only (CVE-2025-62126) - Add debug mode warning in admin settings - Whitelist allowed tab parameter values - Cast $_GET['post_id'] to integer - Fix PHP notice from missing isset() on $_GET['info'] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
current_user_can('manage_options')andcheck_admin_referer()to VCL configuration download handler, which was accessible by unauthenticated users viaadmin-ajax.php(CVE-2025-62126)$_SERVER['HTTP_HOST']when running in WP-CLI contextTest plan
wp-admin/admin-ajax.phpwithoption_page=varnish_caching_downloadis blocked