Meeting prep: inline attendee notes under upcoming meetings#636
Open
Gagancreates wants to merge 3 commits into
Open
Meeting prep: inline attendee notes under upcoming meetings#636Gagancreates wants to merge 3 commits into
Gagancreates wants to merge 3 commits into
Conversation
Resolve a meeting's attendees against the knowledge base and render each attendee's existing person.md inline beneath the next upcoming meeting in the Meetings view. Deterministic (email-exact match, then unambiguous name/alias), no LLM in the hot path. - core: resolveMeetingPrep() + meeting-prep:resolve IPC - renderer: notes-first rows with expandable person.md; unmatched attendees collapse into a 'no notes yet' row with a Create note action that hands off to the Copilot - prep re-resolves when a People note changes
Add a Prep toggle to every eligible meeting row, not just the next one. The next meeting still auto-expands; other meetings resolve their attendee notes lazily when their toggle is opened. All-day and solo events get no toggle.
#2 Matching: resolve the meeting's external companies from attendee email domains (and matched people's Organization field), excluding the user's own domain, and surface those org notes in a Companies section. Normalize display names (strip '(via ...)' suffixes) before name/alias matching. #3 Perf: meeting prep reads a cached knowledge index instead of rescanning the whole knowledge dir on every resolve; invalidated whenever a file under knowledge/ changes (wired to the workspace watcher). Fix: extractField in the knowledge index consumed newlines after the label, so an empty field (e.g. **Role:**) bled the next line's value. Restrict it to spaces/tabs so empty fields resolve to undefined. Also strip the folder prefix from link targets for display (Organizations/Rowboat Labs -> Rowboat Labs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds meeting prep to the Meetings view: for an upcoming meeting, it resolves the attendees against the knowledge base and shows each person's
person.mdinline — deterministically, no LLM in the hot path.✦ Preptoggle that resolves lazily on open.How it works
resolveMeetingPrep()(packages/core/src/knowledge/meeting_prep.ts) +meeting-prep:resolveIPC. Matches email-exact first, then an unambiguous name/alias match (display names normalized to strip(via …)suffixes).knowledge/dir on every resolve; the cache is invalidated whenever a file underknowledge/changes (wired to the workspace watcher).Incidental fix
extractFieldin the knowledge index consumed newlines after a field label, so an empty field (e.g.**Role:**) bled the next line's value. Restricted it to spaces/tabs so empty fields resolve toundefined. Also strips the folder prefix from link targets for display (Organizations/Rowboat Labs→Rowboat Labs).Test
Open the Meetings view; prep appears under the next meeting, and any meeting row exposes a Prep toggle. Verified:
npm run deps,tsc --noEmit(main + renderer), andnpm run lintall clean (no new errors).Notes / follow-ups
PLAN.mdat the repo root documents the design decisions.