Bind missing events#964
Open
live627 wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
Just noticed that those "missing" events are bound to the editor's containing div. Is that a roundabout way to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported events are:
What this PR does
Adds callable events that were only accessible via "signals"
pasterawpastepastehtmlGoal
To eventually replace signals with events. I believe the concept of event listeners is easier to grasp since everything in the JS world uses them.
Question
Should we go one step further and make
init()anddestroy()events too?