fix: allow cache subcommand when ./cache is a directory (fixes #1726)#3743
Open
leno23 wants to merge 2 commits into
Open
fix: allow cache subcommand when ./cache is a directory (fixes #1726)#3743leno23 wants to merge 2 commits into
leno23 wants to merge 2 commits into
Conversation
Only treat a file named `cache` in the working directory as a file to open; a `cache` directory must not hide the `bat cache` subcommand. Fixes sharkdp#1726. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
CI is green on my side (including integration test Ready for review when you have time — thanks! |
Author
|
CI still green — ready for review when convenient. Thanks! |
leno23
added a commit
to leno23/bat
that referenced
this pull request
May 16, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Author
|
Friendly ping — CI is green and this is a small, focused fix for #1726. Happy to adjust if anything is needed. Thanks! |
Author
|
Friendly ping — small focused fix for #1726, CI green. Thanks for any review when you have time. |
Author
|
CI remains green. Gentle ping when convenient — fixes |
Author
|
Friendly ping — |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bat cache --buildfailed on the second run whenBAT_CACHE_PATHpointed to a./cachedirectory in the current working directory:The
cachesubcommand was disabled wheneverPath::new("cache").exists(), including whencacheis a directory created by the previous build.Fix
Only disable the
cachesubcommand whencacheis a file in the working directory (is_file()), matching the original intent in the comment.Tests
cache_build_twice_when_cache_directory_exists_in_cwdintegration testFixes #1726.