Skip to content

fix(core/toggle-button): accessibility consistency in toggle-button#2586

Draft
GayatriK2002 wants to merge 4 commits into
siemens:mainfrom
GayatriK2002:fix-4337/toggle-button-accessibility-update
Draft

fix(core/toggle-button): accessibility consistency in toggle-button#2586
GayatriK2002 wants to merge 4 commits into
siemens:mainfrom
GayatriK2002:fix-4337/toggle-button-accessibility-update

Conversation

@GayatriK2002

@GayatriK2002 GayatriK2002 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

💡 What is the current behavior?

  • The toggle-button-secondary preview example was missing from the main.tsx React preview examples file.
  • Disabled buttons were accessible.

GitHub Issue Number: #
Jira Issue Number: 4337

🆕 What is the new behavior?

  • The toggle-button-secondary preview example has been successfully integrated into the main.tsx React file.
  • Disabled buttons are now correctly inaccessible, preventing unintended interactions.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot

changeset-bot Bot commented Jun 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 701f5e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jun 7, 2026

Copy link
Copy Markdown

Deploy Preview for ix-storybook ready!

Name Link
🔨 Latest commit 701f5e4
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a27bb0ba244640008c0dde9
😎 Deploy Preview https://deploy-preview-2586--ix-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the ToggleButtonSecondary import and its corresponding route /preview/toggle-button-secondary to the React test application. The reviewer suggested sorting both the imports and the route definitions alphabetically to maintain clean and consistent code organization.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines 246 to 250
import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary';
import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary';
import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary';
import ToggleButtonSecondary from './preview-examples/toggle-button-secondary';
import ToggleButtonTertiary from './preview-examples/toggle-button-tertiary';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain clean and consistent code organization, imports should be sorted alphabetically. Currently, ToggleButtonSecondary is placed out of order.

Suggested change
import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary';
import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary';
import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary';
import ToggleButtonSecondary from './preview-examples/toggle-button-secondary';
import ToggleButtonTertiary from './preview-examples/toggle-button-tertiary';
import ToggleButtonSecondary from './preview-examples/toggle-button-secondary';
import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary';
import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary';
import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary';
import ToggleButtonTertiary from './preview-examples/toggle-button-tertiary';

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Comment thread packages/react-test-app/src/main.tsx Outdated
Comment on lines 458 to 462
'/preview/toggle-button-tertiary': ToggleButtonTertiary,
'/preview/toggle-button-secondary': ToggleButtonSecondary,
'/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary,
'/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary,
'/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain clean and consistent code organization, route definitions should be sorted alphabetically. Currently, /preview/toggle-button-secondary and /preview/toggle-button-tertiary are out of order.

Suggested change
'/preview/toggle-button-tertiary': ToggleButtonTertiary,
'/preview/toggle-button-secondary': ToggleButtonSecondary,
'/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary,
'/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary,
'/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary,
'/preview/toggle-button-secondary': ToggleButtonSecondary,
'/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary,
'/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary,
'/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary,
'/preview/toggle-button-tertiary': ToggleButtonTertiary,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant