fix(core/toggle-button): accessibility consistency in toggle-button#2586
fix(core/toggle-button): accessibility consistency in toggle-button#2586GayatriK2002 wants to merge 4 commits into
Conversation
|
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request adds the ToggleButtonSecondary import and its corresponding route /preview/toggle-button-secondary to the React test application. The reviewer suggested sorting both the imports and the route definitions alphabetically to maintain clean and consistent code organization.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary'; | ||
| import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary'; | ||
| import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary'; | ||
| import ToggleButtonSecondary from './preview-examples/toggle-button-secondary'; | ||
| import ToggleButtonTertiary from './preview-examples/toggle-button-tertiary'; |
There was a problem hiding this comment.
To maintain clean and consistent code organization, imports should be sorted alphabetically. Currently, ToggleButtonSecondary is placed out of order.
| import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary'; | |
| import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary'; | |
| import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary'; | |
| import ToggleButtonSecondary from './preview-examples/toggle-button-secondary'; | |
| import ToggleButtonTertiary from './preview-examples/toggle-button-tertiary'; | |
| import ToggleButtonSecondary from './preview-examples/toggle-button-secondary'; | |
| import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary'; | |
| import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary'; | |
| import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary'; | |
| import ToggleButtonTertiary from './preview-examples/toggle-button-tertiary'; |
| '/preview/toggle-button-tertiary': ToggleButtonTertiary, | ||
| '/preview/toggle-button-secondary': ToggleButtonSecondary, | ||
| '/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary, | ||
| '/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary, | ||
| '/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary, |
There was a problem hiding this comment.
To maintain clean and consistent code organization, route definitions should be sorted alphabetically. Currently, /preview/toggle-button-secondary and /preview/toggle-button-tertiary are out of order.
| '/preview/toggle-button-tertiary': ToggleButtonTertiary, | |
| '/preview/toggle-button-secondary': ToggleButtonSecondary, | |
| '/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary, | |
| '/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary, | |
| '/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary, | |
| '/preview/toggle-button-secondary': ToggleButtonSecondary, | |
| '/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary, | |
| '/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary, | |
| '/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary, | |
| '/preview/toggle-button-tertiary': ToggleButtonTertiary, |
|



💡 What is the current behavior?
GitHub Issue Number: #
Jira Issue Number: 4337
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support