fix: guard nil lower chunk in RFC2045.haircut (#433)#434
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Removed checkout step ref specification for CRuby and JRuby because the workflow in sisimai#435 fails.
Member
|
@SAY-5 Thanks for the patch, I've just merged it. |
azumakuniyuki
added a commit
that referenced
this pull request
Jun 8, 2026
azumakuniyuki
added a commit
that referenced
this pull request
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A multipart part that carries a Content-Type header but no blank-line body makes block.split("\n\n", 2) return a single element, so lowerchunk becomes nil and haircut raises NoMethodError on lowerchunk.empty? at rfc2045.rb:203. This defaults lowerchunk to an empty string in that case, matching the existing nil guard for upperchunk just above. Added a haircut case for a header-only part to test/public/rfc2045-test.rb. Fixes #433.