Indicates the insertion position when dragging docs or block icon#17056
Open
TCOTC wants to merge 3 commits into
Open
Indicates the insertion position when dragging docs or block icon#17056TCOTC wants to merge 3 commits into
TCOTC wants to merge 3 commits into
Conversation
Closed
Member
|
按住 shift 是应该没有 dragover__left 这些样式的 |
Contributor
Author
|
按Shift的时候显示光标的话明显不对,所以是显示指示器,但因为插入嵌入块的实现方式跟移动块不一致,所以没法按指示器位置插入。这个问题我搞不定。 |
Member
|
但是也不能显示 dragover__left,否则会合并为超级块 |
Contributor
Author
|
这个还不是重点,现在是 dragover__top 和 dragover__bottom 也不准确,插入的位置不是指示器的位置 |
Member
|
是不是插入的时候没有根据 dragover__xx 进行插入 |
Contributor
Author
|
对,上面说了具体原因,我不懂怎么改 |
Member
|
那就修改为不要显示 dragover__xx 就可以了。 |
Contributor
Author
|
还在改其他的,不太有空,要延后一下 |
Member
|
那我先移除版本,改好了说一声。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
Fix #16882
目前存在的问题:
video.webm
本 PR 进行改进,增加了以下逻辑:
video.webm
但是本 PR 仍然存在我无法解决的缺陷,需要帮助:
按住 Shift 时(插入嵌入块)插入了指示器,但松手之后不会按照指示器的方位来插入,只会插入到段落块的后面。因为这个嵌入块是通过
insertHTML(protyle.lute.SpinBlockDOM(html), protyle, true)插入的,我不懂怎么更换为其他方式。video.webm
本来还想试试能不能按照指示器位置插入外部拖拽进来的视频文件,但感觉应该会遇到跟前面相同的问题,所以先搁置了
Type of change / 变更类型
缺陷修复
新功能
修改文案或增加新语言
Checklist / 检查清单
我对自己的代码进行了自我审查
我拥有所提交代码的完整权利,并同意其以本项目的 AGPL-3.0 许可证授权
devbranch and has no merge conflictsPR 提交到
dev分支,并且没有合并冲突