Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: address review feedback on subscribers migration
Agent-Logs-Url: https://github.com/superdesk/superdesk-client-core/sessions/d3f35282-bf9b-42d6-bdbd-8360c01fcd7d

Co-authored-by: eos87 <124766+eos87@users.noreply.github.com>
  • Loading branch information
Copilot and eos87 authored May 20, 2026
commit 6515fe8a6dc67763a887c423d0c8d568d0a145dc
2 changes: 1 addition & 1 deletion e2e/MIGRATION_REPORT.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
## Migrated specs
- Protractor `e2e/client/specs/workspace_spec.ts` -> `e2e/client/playwright/workspace.spec.ts` [65a6ef935] — Given the authenticated user is on the dashboard, when they use the workspace hotkeys, then the app switches to monitoring, spiked, personal, search, and back to dashboard.
- Protractor `e2e/client/specs/vocabularies_spec.ts` -> `e2e/client/playwright/vocabularies.spec.ts` [4b719937a] — Given the vocabularies settings page is open, when the user edits the Categories vocabulary name and cancels, then the original vocabulary data is restored.
- Protractor `e2e/client/specs/subscribers_spec.ts` -> `e2e/client/playwright/subscribers.spec.ts` [a50a98854] — Given the publish settings page is open, when the user inspects and edits the default subscriber from the snapshot, then the list shows that subscriber and the save button only enables after changing the target type and destination format.
- Protractor `e2e/client/specs/subscribers_spec.ts` -> `e2e/client/playwright/subscribers.spec.ts` [a50a98854] — Given the publish settings page is open, when the user inspects and edits the default subscriber row from the snapshot, then the list shows that subscriber and the save button only enables after changing the target type and destination format.
- Protractor `e2e/client/specs/suggest_spec.ts` -> `e2e/client/playwright/suggest.spec.ts` [df73cc578] — Given an authenticated user opens a new text item, when they open Live suggestions before changing the body, then the suggestions list is empty.

## Blocked
Expand Down
10 changes: 5 additions & 5 deletions e2e/client/playwright/subscribers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@ import {test, expect} from '@playwright/test';
import {restoreDatabaseSnapshot, s} from './utils';

test.describe('subscribers', () => {
const subscriberName = 'Subscriber 1';

test.beforeEach(async ({page}) => {
await restoreDatabaseSnapshot();
await page.goto('/#/settings/publish');
});

test('lists the default subscriber', async ({page}) => {
await expect(page.locator(s('subscriber-item'))).toHaveCount(1);
await expect(page.locator(s(`subscriber-item=${subscriberName}`))).toBeVisible();
const subscriberItems = page.locator(s('subscriber-item'));

await expect(subscriberItems).toHaveCount(1);
await expect(subscriberItems.first()).toBeVisible();
});

test('save button is disabled until subscriber type changes', async ({page}) => {
const subscriberItem = page.locator(s(`subscriber-item=${subscriberName}`));
const subscriberItem = page.locator(s('subscriber-item')).first();

await subscriberItem.click();
await subscriberItem.locator(s('edit-subscriber-button')).click();
Expand Down
Loading