Change bundle caching to only re-check remote once per week#1363
Open
CraftSpider wants to merge 2 commits into
Open
Change bundle caching to only re-check remote once per week#1363CraftSpider wants to merge 2 commits into
CraftSpider wants to merge 2 commits into
Conversation
Uses chrono to write another file in addition to the hash which carries a bundle's last-checked time. This prevents constant re-checks on every engine run.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
+ Coverage 29.54% 29.81% +0.27%
==========================================
Files 273 273
Lines 180510 180538 +28
Branches 180510 180538 +28
==========================================
+ Hits 53328 53825 +497
+ Misses 55480 54489 -991
- Partials 71702 72224 +522
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
So, without this, every build on Tectonic-on-arXiv is failing. With it, only most are. So that's good :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses chrono to write another file in addition to the hash which carries a bundle's last-checked time. This prevents constant re-checks on every engine run. This is important because nearly half of tectonic's runtime is spent reading the entire bundle off the internet on every invocation.
@rm-dr, since you did the original bundle rework.