Skip to content

Crash fixes and general stability improvements #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbeBryssinck merged 11 commits into from
Apr 19, 2022
Merged

Crash fixes and general stability improvements #123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cf10fc2
tweak: disable d3d11 check
RobbeBryssinck Apr 14, 2022
3a78d1d
tweak: update server-side weapon draw state
RobbeBryssinck Apr 14, 2022
186cd6b
tweak: removed unnecessary data from RemoteComponent
RobbeBryssinck Apr 14, 2022
568b6c6
fix: inventory related crashes
RobbeBryssinck Apr 14, 2022
e2835c7
tweak: unpause container and barter menus
RobbeBryssinck Apr 14, 2022
b816f87
tweak: unpause book and favorites menu
RobbeBryssinck Apr 14, 2022
c1cfc54
tweak: redid old RE actor value code
RobbeBryssinck Apr 15, 2022
eb84847
tweak: actor values debugger
RobbeBryssinck Apr 15, 2022
7ed909a
Merge branch 'master' into stability
RobbeBryssinck Apr 18, 2022
21413ac
tweak: logging levels
RobbeBryssinck Apr 18, 2022
e0391dd
tweak: revert file log level for now
RobbeBryssinck Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak: unpause book and favorites menu
  • Loading branch information
@RobbeBryssinck
RobbeBryssinck committed Apr 14, 2022
commit b816f873889f6b77bcd28b070b2503a2788b1525
2 changes: 1 addition & 1 deletion Code/client/Games/Skyrim/Interface/UI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static void UnfreezeMenu(IMenu* apEntry)

static constexpr const char* kAllowList[] = {
"Console", "TweenMenu", "MagicMenu", "StatsMenu", "InventoryMenu", "MessageBoxMenu",
"ContainerMenu", "BarterMenu"
"ContainerMenu", "BarterMenu", "Book Menu", "FavoritesMenu"
//"MapMenu", // MapMenu is disabled till we find a proper fix for first person.
//"Journal Menu", // Journal menu, aka pause menu, is disabled until we find a fix for manual save crashing while unpaused.
};
Expand Down
1 change: 1 addition & 0 deletions Code/client/TiltedOnlineApp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ TiltedOnlineApp::TiltedOnlineApp()
create_directory(logPath, ec);

auto rotatingLogger = std::make_shared<spdlog::sinks::rotating_file_sink_mt>(logPath / "tp_client.log", 1048576 * 5, 3);
rotatingLogger->set_level(spdlog::level::debug);

@Force67 Force67 Apr 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this off for stable builds?

@RobbeBryssinck RobbeBryssinck Apr 19, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rotatinglogger logs to file, not the console. I didn't fully complete it in this PR, but the goal is to somehow send these logs to Sentry on crash, if that's somehow possible.

@Force67 Force67 Apr 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the sentry native documentation, it allows you to attach other files to crashes :)

@RobbeBryssinck RobbeBryssinck Apr 19, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that'd be perfect, I'll do that in a follow up PR then 👍

@maximegmd maximegmd Apr 19, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be info at most in stable yea, apart from that I see no problem

auto console = std::make_shared<spdlog::sinks::stdout_color_sink_mt>();
console->set_pattern("%^[%H:%M:%S] [%l]%$ %v");

Expand Down