feat: improved quest debugger

Code/client/Events/MoveActorEvent.h

@@ -0,0 +1,13 @@
+#pragma once
+
+struct MoveActorEvent
+{
+    MoveActorEvent(uint32_t aFormId, uint32_t aCellId, NiPoint3 aPosition)
+        : FormId(aFormId), CellId(aCellId), Position(aPosition)
+    {
+    }
+
+    uint32_t FormId;
+    uint32_t CellId;
+    NiPoint3 Position;
+};

Code/client/Games/Skyrim/Forms/TESQuest.cpp

@@ -4,6 +4,17 @@
 
 #include <Games/Overrides.h>
 
+TESObjectREFR* TESQuest::GetAliasedRef(uint32_t aAliasID) noexcept
+{
+    TP_THIS_FUNCTION(TGetAliasedRef, BSPointerHandle<TESObjectREFR>*, TESQuest, BSPointerHandle<TESObjectREFR>*, uint32_t);
+    POINTER_SKYRIMSE(TGetAliasedRef, getAliasedRef, 25066);
+
+    BSPointerHandle<TESObjectREFR> result{};
+    ThisCall(getAliasedRef, this, &result, aAliasID);
+
+    return TESObjectREFR::GetByHandle(result.handle.iBits);
+}
+
 TESQuest::State TESQuest::getState()
 {
     if (flags >= 0)

Code/client/Games/Skyrim/Forms/TESQuest.h

@@ -5,6 +5,12 @@
 #include <Components/TESFullName.h>
 #include <Forms/BGSStoryManagerTree.h>
 
+struct BGSScene : TESForm
+{
+    GameArray<void*> phases;
+    GameArray<uint32_t> actorIds;
+};
+
 struct TESQuest : BGSStoryManagerTreeForm
 {
     enum class State : uint8_t
@@ -91,7 +97,7 @@ struct TESQuest : BGSStoryManagerTreeForm
     */
     GameList<Objective> objectives;    // 0x00F8
     char pad108[0x100];                // 0x0108
-    GameArray<void*> scenes;           // 0x0208
+    GameArray<BGSScene*> scenes;       // 0x0208
     char pad210[8];                    // 0x0210
     uint16_t currentStage;             // 0x0228 
     bool alreadyRun;                   // 0x022A
@@ -101,6 +107,8 @@ struct TESQuest : BGSStoryManagerTreeForm
     uint64_t unkFlags;
     char pad250[24];
 
+    TESObjectREFR* GetAliasedRef(uint32_t aiAliasID) noexcept;
+
     bool IsStageDone(uint16_t stageIndex);
     void SetCompleted(bool force);
 

Code/client/Services/Debug/DebugService.cpp

@@ -14,6 +14,7 @@
 #include <Events/UpdateEvent.h>
 #include <Events/DialogueEvent.h>
 #include <Events/SubtitleEvent.h>
+#include <Events/MoveActorEvent.h>
 
 #include <Games/References.h>
 
@@ -97,6 +98,7 @@ DebugService::DebugService(entt::dispatcher& aDispatcher, World& aWorld, Transpo
     m_drawImGuiConnection = aImguiService.OnDraw.connect<&DebugService::OnDraw>(this);
     m_dialogueConnection = m_dispatcher.sink<DialogueEvent>().connect<&DebugService::OnDialogue>(this);
     m_dispatcher.sink<SubtitleEvent>().connect<&DebugService::OnSubtitle>(this);
+    m_dispatcher.sink<MoveActorEvent>().connect<&DebugService::OnMoveActor>(this);
 }
 
 void DebugService::OnDialogue(const DialogueEvent& acEvent) noexcept
@@ -115,11 +117,40 @@ void DebugService::OnSubtitle(const SubtitleEvent& acEvent) noexcept
     SubtitleText = acEvent.Text;
 }
 
+// TODO: yeah, i'm aware of how dumb this looks, but things crash if
+// you do it directly by adding an event to the queue, no symbols for tiltedcore when debugging,
+// so this'll do for now
+struct MoveData
+{
+    Actor* pActor = nullptr;
+    TESObjectCELL* pCell = nullptr;
+    NiPoint3 position;
+} moveData;
+
+void DebugService::OnMoveActor(const MoveActorEvent& acEvent) noexcept
+{
+    Actor* pActor = Cast<Actor>(TESForm::GetById(acEvent.FormId));
+    TESObjectCELL* pCell = Cast<TESObjectCELL>(TESForm::GetById(acEvent.CellId));
+
+    if (!pActor || !pCell)
+        return;
+
+    moveData.pActor = pActor;
+    moveData.pCell = pCell;
+    moveData.position = acEvent.Position;
+}
+
 void DebugService::OnUpdate(const UpdateEvent& acUpdateEvent) noexcept
 {
     if (!BSGraphics::GetMainWindow()->IsForeground())
         return;
 
+    if (moveData.pActor)
+    {
+        moveData.pActor->MoveTo(moveData.pCell, moveData.position);
+        moveData.pActor = nullptr;
+    }
+
     static std::atomic<bool> s_f8Pressed = false;
     static std::atomic<bool> s_f7Pressed = false;
     static std::atomic<bool> s_f6Pressed = false;
@@ -167,13 +198,16 @@ void DebugService::OnUpdate(const UpdateEvent& acUpdateEvent) noexcept
         {
             s_f8Pressed = true;
 
+            Actor* pActor = Cast<Actor>(TESForm::GetById(0x1a677));
+            pActor->MoveTo(PlayerCharacter::Get()->parentCell, PlayerCharacter::Get()->position);
+
+        #if 0
             static bool s_enabled = true;
 
             FadeOutGame(s_enabled, true, 1.f, true, 0.f);
 
             s_enabled = !s_enabled;
 
-        #if 0
             static bool s_enabled = true;
             static bool s_firstPerson = false;
 

Code/client/Services/Debug/Views/EntitiesView.cpp

@@ -181,7 +181,8 @@ void DebugService::DisplayLocalComponent(LocalComponent& aLocalComponent, const
         m_world.GetRunner().Queue([acFormId]() {
             Actor* pActor = Cast<Actor>(TESForm::GetById(acFormId));
             PlayerCharacter* pPlayer = PlayerCharacter::Get();
-            pActor->MoveTo(pPlayer->parentCell, pPlayer->position);
+            if (pActor)
+                pActor->MoveTo(pPlayer->parentCell, pPlayer->position);
         });
     }
 

Code/client/Services/Debug/Views/QuestDebugView.cpp

@@ -4,6 +4,9 @@
 
 #include <PlayerCharacter.h>
 #include <Forms/TESQuest.h>
+#include <Forms/TESObjectCELL.h>
+
+#include <Events/MoveActorEvent.h>
 
 #include <imgui.h>
 
@@ -30,25 +33,58 @@ void DebugService::DrawQuestDebugView()
 
         foundQuests.insert(pQuest->formID);
 
-        if (pQuest->IsActive())
-        {
-            ImGui::TextColored({255.f, 0.f, 255.f, 255.f}, "%s|%x|%s", pQuest->idName.AsAscii(),
-                               pQuest->flags, pQuest->fullName.value.AsAscii());
+        if (!pQuest->IsActive())
+            continue;
 
-            for (auto* stage : pQuest->stages)
+        char questName[256];
+        sprintf_s(questName, std::size(questName), "%s (%s)", pQuest->fullName.value.AsAscii(), pQuest->idName.AsAscii());
+        if (!ImGui::CollapsingHeader(questName))
+            continue;
+
+        if (ImGui::CollapsingHeader("Stages"))
+        {
+            for (auto* pStage : pQuest->stages)
             {
-                ImGui::TextColored({0.f, 255.f, 255.f, 255.f}, "Stage: %d, is done? %s", stage->stageIndex, stage->IsDone() ? "true" : "false");
+                ImGui::TextColored({0.f, 255.f, 255.f, 255.f}, "Stage: %d, is done? %s", pStage->stageIndex, pStage->IsDone() ? "true" : "false");
 
                 char setStage[64];
-                sprintf_s(setStage, std::size(setStage), "Set stage (%d)", stage->stageIndex);
+                sprintf_s(setStage, std::size(setStage), "Set stage (%d)", pStage->stageIndex);
 
                 if (ImGui::Button(setStage))
-                    pQuest->ScriptSetStage(stage->stageIndex);
+                    pQuest->ScriptSetStage(pStage->stageIndex);
             }
         }
-        else
+
+        if (ImGui::CollapsingHeader("Actors"))
         {
-            ImGui::Text("%s|%x|%s", pQuest->idName.AsAscii(), pQuest->flags, pQuest->fullName.value.AsAscii());
+            Set<uint32_t> foundActors{};
+
+            for (BGSScene* pScene : pQuest->scenes)
+            {
+                for (uint32_t actorId : pScene->actorIds)
+                {
+                    Actor* pActor = Cast<Actor>(pQuest->GetAliasedRef(actorId));
+                    if (!pActor)
+                        continue;
+
+                    if (foundActors.contains(pActor->formID))
+                        continue;
+
+                    foundActors.insert(pActor->formID);
+
+                    char name[256];
+                    sprintf_s(name, std::size(name), "%s (%x)", pActor->baseForm->GetName(), pActor->formID);
+                    ImGui::BulletText(name);
+
+                    ImGui::PushID(pActor->formID);
+                    if (ImGui::Button("Teleport to me"))
+                    {
+                        auto* pPlayer = PlayerCharacter::Get();
+                        m_world.GetRunner().Trigger(MoveActorEvent(pActor->formID, pPlayer->parentCell->formID, pPlayer->position));
+                    }
+                    ImGui::PopID();
+                }
+            }
         }
     }
 

Code/client/Services/DebugService.h

@@ -8,6 +8,7 @@ struct ImguiService;
 struct UpdateEvent;
 struct DialogueEvent;
 struct SubtitleEvent;
+struct MoveActorEvent;
 
 struct TransportService;
 struct BSAnimationGraphManager;
@@ -25,6 +26,7 @@ struct DebugService
     void OnUpdate(const UpdateEvent&) noexcept;
     void OnDialogue(const DialogueEvent&) noexcept;
     void OnSubtitle(const SubtitleEvent&) noexcept;
+    void OnMoveActor(const MoveActorEvent&) noexcept;
 
     void SetDebugId(const uint32_t aFormId) noexcept;