New inventory system#60
Merged
Merged
Conversation
Force67
reviewed
Mar 16, 2022
|
|
||
| AlchemyItem* pPoison; | ||
| uint32_t uiCount; | ||
| AlchemyItem* pPoison{}; |
Force67
reviewed
Mar 16, 2022
| if (!m_transport.IsOnline()) | ||
| m_transport.Connect(s_address); | ||
| else | ||
| m_transport.Close(); |
|
|
||
| BGSCreatedObjectManager* BGSCreatedObjectManager::Get() noexcept | ||
| { | ||
| POINTER_SKYRIMSE(BGSCreatedObjectManager*, pObjManager, 400320); |
Member
There was a problem hiding this comment.
s_instance instead of pObjManager
|
Dumb question: Is it hard to add the capability of sharing crafted potions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new system builds up a custom inventory with all relevant extra data (as far as I was able to enumerate it). This means individual items can now also be manipulated by the server. The inventories and their items can be exposed to a server side scripting API.
The system could be further optimized by adding and removing individual items on change instead of sending over the entire inventory every time it changes, but for testing purposes, I will do that for the next test build. Custom names for items are not synced yet, since this was causing some crashes, but I can add this at a later date.
This new system should fix 90% of the crashes that the playtesters are experiencing.