Skip to content

Bugfix: Prevent players from recruiting pets on public servers and cause crashes #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbeBryssinck merged 2 commits into from
Dec 2, 2024
Merged

Bugfix: Prevent players from recruiting pets on public servers and cause crashes #749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf1b9a0
Default PetFramework scripts to be edited
absol89 Nov 30, 2024
138e14d
Bugfix: Prevent players from recruiting pets on public servers and ca…
absol89 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Bugfix: Prevent players from recruiting pets on public servers and ca… 
…use crashes

Displays the dismiss message and returns, instead of making the CC pet stalk the party
  • Loading branch information
@absol89
absol89 committed Nov 30, 2024
commit 138e14d95bfe2df959e72a43e74e9377c9fb4288
Binary file added GameFiles/Skyrim/scripts/PetFramework_ParentQuestScript.pex
View file
Open in desktop
Binary file not shown.
Binary file added GameFiles/Skyrim/scripts/petframework_petquest.pex
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion GameFiles/Skyrim/scripts/source/PetFramework_ParentQuestScript.psc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ Faction Property PlayerFaction Auto
Faction Property CWSonsFaction Auto
Faction Property CWImperialFaction Auto

Int Property CurrentPetCount = 0 Auto Hidden ;Current count of pets, this is manipulated by pet ESPs/ESLs using the functions below
; Setting start CurrentPetCount over the Max so the player cannot dismiss 2 pets and recruit new ones while online. Hypothetically.
Int Property CurrentPetCount = 4 Auto Hidden ;Current count of pets, this is manipulated by pet ESPs/ESLs using the functions below

Event OnInit()
debug.trace("Setting pet and player relationship to ally")
Expand Down
3 changes: 2 additions & 1 deletion GameFiles/Skyrim/scripts/source/PetFramework_PetQuest.psc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ Function FollowPlayer(Bool snapIntoInteraction = False)
If(PetFramework_ParentQuest.HasMaxPets())
PetFramework_PetMaxReachedMessage.Show()
Else

PetFramework_PetDismissMessage.Show()
return ; STR players ignore the pets.
debug.trace("Pet Framework: " + PetRefAlias.GetActorReference() + " setting to following player")
debug.trace("Pet Framework: " + PetRefAlias.GetActorReference() + " PetFollowingFactionRank: " + PetRefAlias.GetActorReference().GetFactionRank(PetFramework_PetFollowingFaction))

Expand Down