Server: prevent Party auto-join when bAnnounceServer is true to prevent public server trolling#874
Open
absol89 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adresses players who public server hop to teleport to other players and grief them and pollute their quest progress.
The changes in this PR have been tested with OnPartyCreate, and I added OnPlayerJoin safeguard as the last commit june 16.
This does not affect players playing privately, or using playtogether.gg, as those use the connect UI with private IP and port.
Before: Player joined and instantly got autojoined to the party (default setting), and proceeded to share progress + location.
After: Player joined a public server and has to type to request a party invite from the previous players, to affect their savefile.
Note: The compile fix commit is not really relevant, it was just an attempt to read the variable from elsewhere, but i learned that it was static there and that the variable cannot be changed at runtime, so just having a copy of the setting in partyservice seems to be enough. The variable is used in ServerListService.cpp as well