This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Feature: Getters for scenevideo and gazedata urls#64
Merged
Conversation
Markus Wesslén (m4reko)
force-pushed
the
dev
branch
from
ef4965e to
57494ed
Compare
Markus Wesslén (m4reko)
force-pushed
the
feature/replay-url
branch
from
e4c0cfe to
6a9c012
Compare
Markus Wesslén (m4reko)
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds aiohttp as a dependency with the Apache Software License (Apache 2). This should be ok after a quick google search.
The tests for the new getters make a request using the urls and check that the response status is 200. Any opinions on this?
Also, any opinions on the error handling on line 174 and 190 in recording.py?
Resolves #61